chore(bundler-plugins): Allow magic-string 1.x - #24768
Open
EmileBrunelle wants to merge 5 commits into
Open
EmileBrunelle wants to merge 5 commits into
EmileBrunelle wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…leBrunelle/sentry-javascript into chore/bundler-plugins-magic-string-1
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19510 / #19520:
@sentry/bundler-pluginspinsmagic-stringto~0.30.8, so apps whose other tooling already moved to 1.x (e.g. vitest) install two copies.This widens the range to
~0.30.8 || ^1.0.0instead of forcing 1.x. Apps get whichever copy they already have. That matters because@sentry/nextjsitself still brings 0.30 through@rollup/plugin-commonjs, so a hard^1would create the duplicate this is meant to remove.~stays on the 0.30 side, as #19520 intended.1.0.0's only breaking change is ESM-only packaging (no top-level await, no API changes up to 1.4.2). The package's engines field is already the
require(esm)floor, so the CJS build works with both. I checked the 1.x side byrequire()-ingbuild/cjsfrom a plain.cjsscript and running the component-annotation transform, on Node 20.19.0, 22.12.0, 22.13.0 and 24. The only difference: Node 22.12.x prints Node'srequire(esm)ExperimentalWarning once at build time. 22.13.0+ and 20.19.0 print nothing.@sentry/svelte,@sentry/sveltekitand@sentry/cloudflarehave the same engines floor and still use~0.30. I'm happy to send the same change for them separately.