Conversation
TTFB, FP and FCP are attributes of the pageload span rather than spans of their own, so unlike LCP, CLS and INP they had no navigation type to be read against. Report the type web-vitals measured TTFB and FCP on as an attribute of the pageload span.
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 974b664. Configure here.
logaretm
marked this pull request as ready for review
September 18, 2026 15:18
logaretm
requested review from
msonnb and
mydea
and removed request for
a team
September 18, 2026 15:18
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTFB, FP and FCP live on the pageload span as attributes and had no navigation type to be read against.
I added
browser.navigation.typeon that span so it also shows whether it was restored/back-forward-no-cache navigated as well or whether it was a pre-render.Core web vitals were already emitted with the attributes, just not the entire web (non-core) web vitals that we already emit.