Conversation
Contributor
size-limit report 📦
|
mydea
added this pull request to stack #24369
September 15, 2026 08:31
mydea
changed the title
Mirror the node-mastra e2e app on Cloudflare Workers (Vite + workerd) to cover the most common non-Node way users run Mastra. Instrumentation is wired at build time by @sentry/cloudflare/vite (orchestrion channels injected into @mastra/core; mastraIntegration self-registers via the global marker), with options sourced from instrument.server.ts. Adapts for workerd: the Mastra instance is constructed lazily inside fetch (so it runs after withSentry has subscribed), uses InMemoryStore instead of @mastra/libsql, and configures @mastra/observability explicitly with a placeholder exporter (the SDK's createRequire-based bootstrap can't run in a bundled worker). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
On Cloudflare the Mastra integration could not bootstrap Mastra's observability pipeline: it resolves `@mastra/observability` via `createRequire`, which has no on-disk `node_modules` in workerd, so users had to construct and wire up an `Observability` themselves. `@sentry/cloudflare/vite` now splices a static `import * as ns from '@mastra/observability'` into Sentry's own Mastra integration module (only when the package resolves) and stashes the namespace on a generic `__SENTRY_ORCHESTRION__.providedModules` marker. The integration reads it there before falling back to `createRequire`, so Mastra tracing works with zero observability config — the same DX as Node. Simplifies the cloudflare-mastra e2e app to drop its placeholder observability config accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/cloudflare-mastra-e2e
branch
from
September 15, 2026 10:24
17f167c to
3541554
Compare
mydea
marked this pull request as ready for review
September 15, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Cloudflare coverage for Mastra — the most common non-Node way users run Mastra — as a Vite + workerd e2e app (
cloudflare-mastra), and fixes the one thing that stopped it working with zero config.On Cloudflare the Mastra integration couldn't bootstrap Mastra's observability pipeline: it resolves
@mastra/observabilityviacreateRequire, which has no on-disknode_modulesin workerd, so users had to construct and wire up anObservabilitythemselves. Now@sentry/cloudflare/vitesplices a staticimport * as ns from '@mastra/observability'into Sentry's own Mastra integration module — only when the package resolves — and records the namespace on a generic__SENTRY_ORCHESTRION__.providedModulesmarker; the integration reads it there before falling back tocreateRequire. Mastra tracing on Cloudflare now works with no observability config, matching the Node DX. The import lands in Sentry's module (not user code), stays statically analyzable (no lazyimport()/createRequirein the bundle), and no-ops when Mastra isn't used.Requires
@mastra/observabilityto be an app dependency. The SDK never installs or bundles it — it is Mastra's tracing engine (the span factory), and without it Mastra emits only no-op spans, so there is nothing to capture. This is not new or Cloudflare-specific: it is equally required on Node, where the integration bootstraps from the@mastra/observabilitythe app already has. On Cloudflare the Vite plugin's injection is additionally gated on it resolving at build time; if it is absent the plugin no-ops and no spans are produced (same net effect as Node).The e2e app mirrors the
node-mastraassertions (agent/model/toolgen_aispans, tool-error capture, orchestriondataloadernesting, anhttp.serverspan) against the Cloudflare instrumentation path, where orchestrion runs at build time. Its tool/dataloader assertions run against a live model via the existingE2E_OPENROUTER_API_KEY; themanual-routetest needs no key.🤖 Generated with Claude Code