feat(ember): Give component definition lookups their own span op - #24271
Draft
Lms24 wants to merge 2 commits into
Draft
feat(ember): Give component definition lookups their own span op#24271Lms24 wants to merge 2 commits into
Lms24 wants to merge 2 commits into
Conversation
Ember spans that resolve a component definition were using the `function` op, which infers a span description of "Function execution" and loses the component name. They now use `ui.resolve`, a new op proposed in getsentry/sentry-conventions#633. The op is hard-coded with a TODO until that lands and we can import the const. Route hook spans keep the route as `sentry.description` and are named after the hook when span streaming is on, so the name matches `code.function.name` (the `function` op's name template) in both trace lifecycles. Also converts the `ember-classic` E2E app to span streaming and turns on `enableComponentDefinitions` there, so `ui.resolve` gets covered. That flag was off in every app, so the code path had never run in CI. `ember-embroider` and `ember-vite` still cover the static lifecycle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
The conversion weakened every child span check: status, span_id, trace_id, both timestamps and the exact attribute set were gone, and parent_span_id had become a filter rather than an assertion. Two of the segment spans also lost `url.path` and `url.full`. `expectChildSpan` puts all of them back on all 8 child spans. Exact attribute matching needs the SDK's own attributes stripped first, since every streamed span carries the segment, sdk, replay and user-agent ones. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember spans that resolve a component definition used the
functionop, which infers a description of "Function execution" and loses the component name. Switching them toui.renderwould have collided with the render span that follows: same name, sameui.component_name. So they now useui.resolve, a new op proposed in getsentry/sentry-conventions#633. It is hard-coded with a TODO until that lands and we can import the const.Route hook spans keep the route as
sentry.descriptionand are named after the hook when span streaming is on, so the name matchescode.function.name. This also converts theember-classicE2E app to span streaming and turns onenableComponentDefinitionsthere, which is what coversui.resolve— that flag was off in every app, so the code path had never run in CI.ember-embroiderandember-vitestill cover the static lifecycle.🤖 Generated with Claude Code