feat(effect): Set code.function.name attribute for span description inference - #24261
Closed
Lms24 wants to merge 2 commits into
Closed
feat(effect): Set code.function.name attribute for span description inference#24261Lms24 wants to merge 2 commits into
code.function.name attribute for span description inference#24261Lms24 wants to merge 2 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3eb1e36. Configure here.
Contributor
size-limit report 📦
|
Member
Author
|
Ok so i think we should just remove the fallback op for function instead. we don't know at all what calls this helper so I'd rather not pretend these are sentry-created spans. |
Member
Author
|
superseded by #24263 |
Lms24
added a commit
that referenced
this pull request
Sep 11, 2026
Initially, in #24261, I just wanted to enhance `function` spans in Effect but then realized when looking at the test changes that we likely shouldn't set a `function` op on these spans at all. IIUC, our wrapper can either be called by users or by other libraries that emit spans. From these spans, we try to infer an op (`http.client` and `http.server` at the moment). However, falling back to `function` for all other spans doesn't sound right to me because these could be any kinds of span. Therefore, this PR - changes our op inference logic to just return no op - likewise, changes our origin inference logic to return `manual` for spans we don't know - => makes it seem like these spans were user-emitted. - adjusts tests My thinking is: We likely need to improve the inference logic if we know that certain libraries' spans go through our wrapper. Thinking of db, queue, request, etc. spans. But `function` likely isn't the fallback we want to use. The side-effect: Spans with `sentry.origin: "manual"` double write span name and description, so no low card. span name stuff applies to them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect spans fall back to op
functionwhen we don't detect spans that should be ophttp.serverorhttp.client. I'm going to assume this is intended and moreover, assume that these spans are actual function spans. This is good because it means they're already low cardinality and adhere to the conventions span name spec. So the only thing left to do was setting thecode.function.nameattribute for span description inference.ref #23954