feat(cloudflare): Emit low cardinality function span names and preserve span descriptions - #24246
Draft
Lms24 wants to merge 2 commits into
Draft
feat(cloudflare): Emit low cardinality function span names and preserve span descriptions#24246Lms24 wants to merge 2 commits into
function span names and preserve span descriptions#24246Lms24 wants to merge 2 commits into
Conversation
Lms24
changed the title
function span names and preserve span descriptions
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e6561f. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few adjustments to cloudflare
sentry.op: "function"spans:namefor both, streaming and transaction mode.scheduled(like the handled function name). Because we can't map the static string via span inference for function spans in Relay, I added the old name as asentry.descriptionoverride to avoid span description inference for streamed spans. For transactions, nothing changeswrapMethodWithSentry- wrapped spans: Any spans that were previously of opfunctionare already named after their function name (🎉). Therefore we only need to add thecode.function.nameattribute for description inference and we're good.Adjusted tests and added note in migration guide.