Skip to content

feat(angular): Emit low cardinality TraceMethod span name and preserve description - #24239

Open
Lms24 wants to merge 5 commits into
developfrom
lms/feat-angular-traceMethod-span-name
Open

feat(angular): Emit low cardinality TraceMethod span name and preserve description#24239
Lms24 wants to merge 5 commits into
developfrom
lms/feat-angular-traceMethod-span-name

Conversation

@Lms24

@Lms24 Lms24 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Adjusts the function span name for @TraceMethod decorator spans in the Angular SDK:

  • emit the low-cardinality user-supplied name as the span name
  • preserve the span description by explicitly setting the sentry.description attribute. We can't model the special case we had here previously with convention description inference rules, so we need to override inference by directly setting this attribute.
  • transaction span description stays untouched (Angular 19 e2e tests are still on transactions and require no changes, which proves this)

ref #23954

@Lms24
Lms24 requested a review from a team as a code owner September 9, 2026 11:05
@Lms24
Lms24 requested review from mydea and nicohrubec and removed request for a team September 9, 2026 11:05
@Lms24 Lms24 changed the title feat(angular): Emit low cardinality TraceMethod span name and preserve description feat(angular): Emit low cardinality TraceMethod span name and preserve description Sep 9, 2026
@Lms24 Lms24 self-assigned this Sep 9, 2026
Comment thread packages/angular/src/tracing.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c0dbb63. Configure here.

Comment thread packages/angular/src/tracing.ts Outdated
Comment thread packages/angular/src/tracing.ts
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.81 kB +0.04% +11 B 🔺
@sentry/browser - with treeshaking flags 27.12 kB +0.04% +10 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 27.01 kB +0.03% +7 B 🔺
@sentry/browser (incl. Tracing) 49.22 kB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 49.22 kB +0.02% +5 B 🔺
@sentry/browser (incl. Tracing, Profiling) 52.15 kB +0.05% +21 B 🔺
@sentry/browser (incl. Tracing, Replay) 88.76 kB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.94 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 93.44 kB +0.01% +1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 106.38 kB +0.01% +10 B 🔺
@sentry/browser (incl. Feedback) 46.3 kB +0.02% +5 B 🔺
@sentry/browser (incl. sendFeedback) 33.87 kB +0.02% +6 B 🔺
@sentry/browser (incl. FeedbackAsync) 38.99 kB +0.04% +13 B 🔺
@sentry/browser (incl. Metrics) 29.84 kB +0.08% +23 B 🔺
@sentry/browser (incl. Logs) 30.1 kB +0.06% +18 B 🔺
@sentry/browser (incl. Metrics & Logs) 30.78 kB +0.11% +31 B 🔺
@sentry/react 30.57 kB +0.05% +14 B 🔺
@sentry/react (incl. Tracing) 51.57 kB +0.03% +12 B 🔺
@sentry/vue 36.07 kB +0.05% +17 B 🔺
@sentry/vue (incl. Tracing) 51.49 kB +0.04% +19 B 🔺
@sentry/svelte 28.85 kB +0.06% +15 B 🔺
CDN Bundle 30.56 kB +0.05% +15 B 🔺
CDN Bundle (incl. Tracing) 49.76 kB +0.06% +25 B 🔺
CDN Bundle (incl. Logs, Metrics) 32.83 kB +0.03% +9 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 51.7 kB -0.01% -1 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 73.48 kB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay) 87.28 kB -0.01% -8 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 89.2 kB +0.03% +20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 93.21 kB -0.01% -3 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 95.22 kB +0.01% +8 B 🔺
CDN Bundle - uncompressed 90.47 kB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 148.17 kB -0.01% -1 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.04 kB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 154.13 kB -0.01% -1 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 226.3 kB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.76 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 273.71 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.46 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 287.4 kB -0.01% -1 B 🔽
@sentry/nextjs (client) 54.03 kB +0.06% +31 B 🔺
@sentry/sveltekit (client) 49.68 kB +0.06% +26 B 🔺
@sentry/core/server 36.99 kB - -
@sentry/core/browser 13.55 kB - -
@sentry/node 127.86 kB +0.06% +67 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.61 kB - -
@sentry/node - without tracing 88.73 kB +0.03% +22 B 🔺
@sentry/node - without channel injection 107.11 kB +0.08% +81 B 🔺
@sentry/aws-serverless 97.12 kB +0.03% +27 B 🔺
@sentry/cloudflare (withSentry) - minified 201.98 kB - -
@sentry/cloudflare (withSentry) 502.68 kB - -

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant