test(e2e): Port nextjs-14 to span streaming - #23921
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
force-pushed
the
test/e2e-port-nextjs-14
branch
from
September 2, 2026 10:14
eaaefe1 to
26f0090
Compare
chargome
force-pushed
the
test/e2e-port-nextjs-14
branch
from
September 2, 2026 10:23
26f0090 to
2d6f137
Compare
chargome
force-pushed
the
test/e2e-port-nextjs-14
branch
from
September 2, 2026 10:58
2d6f137 to
b26b769
Compare
chargome
marked this pull request as ready for review
September 2, 2026 13:15
Lms24
approved these changes
Sep 2, 2026
| status: 'ok', | ||
| trace_id: expect.stringMatching(/[a-f0-9]{32}/), | ||
| attributes: expect.objectContaining({ | ||
| 'sentry.origin': { value: 'auto', type: 'string' }, |
Member
There was a problem hiding this comment.
what sentry.op does this span have? (just wondering because the name looks like it needs treatment (out of scope for this PR)
| 'http.request.method': 'GET', | ||
| 'sentry.op': 'http.client', | ||
| 'sentry.origin': 'auto.http.node_fetch', | ||
| name: 'GET github.com', |
Member
There was a problem hiding this comment.
l: might make sense to assert on url.full attributes here
Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans. Tests asserting on children of a segment span (generation functions, request instrumentation, trace propagation) use `collectStreamedSpans` and accumulate until the segment span, which ends last. The propagation specs match the inbound span, outbound span and the `http.client` span between them within one trace, since all three share it. `http.client` span names are low cardinality under streaming, so the request-instrumentation spans are now named `GET github.com` rather than `GET https://github.com/`. The transaction-side `tags` assertions were dropped, having no span v2 equivalent; the error-side assertions still cover isolation scope. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
test/e2e-port-nextjs-14
branch
from
September 2, 2026 13:43
b26b769 to
1499f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-14to span streaming: removes thetraceLifecycle: 'static'pins and rewrites the specs onto streamed spans, usingcollectStreamedSpanswhere a test asserts on children of a segment span.http.clientspan names are low cardinality under streaming, so the request-instrumentation spans are asserted asGET github.com. Transaction-sidetagsassertions were dropped; the error-side ones still cover isolation scope.Ref #23802