test(e2e): Port SolidStart SPA and import-variant E2E apps to span streaming - #23919
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
…reaming Removes the static trace lifecycle pin from solidstart-spa, solidstart-dynamic-import and solidstart-top-level-import. The SPA pageload is a client-rendered POST of the server action, so both specs match that segment rather than a GET of the route. Closes: #23810 Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
rolaabuhasna/js-3494/solidstart-2
branch
from
September 2, 2026 10:58
397dfc4 to
045963d
Compare
RulaKhaled
force-pushed
the
rolaabuhasna/js-3494/import-variants
branch
from
September 2, 2026 10:58
eb63069 to
22570bd
Compare
RulaKhaled
changed the base branch from
rolaabuhasna/js-3494/solidstart-2
to
develop
September 2, 2026 11:00
RulaKhaled
marked this pull request as ready for review
September 2, 2026 11:52
andreiborza
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
solidstart-spa,solidstart-dynamic-importandsolidstart-top-level-importto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. The SPA pageload is a client-rendered POST of the server action rather than a GET of the route, so both SPA server specs match that segment. The SSR import variants match the pageload http.server span on
url.pathfor the same low-cardinality reason as the other SolidStart ports.Part of #23810