test(e2e): Port cloudflare-workers to span streaming and keep a static copy - #23855
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/cloudflare-workers-e2e-span-streaming
branch
from
September 1, 2026 15:21
8ae43ba to
16e2bf2
Compare
JPeer264
marked this pull request as ready for review
September 2, 2026 05:47
JPeer264
force-pushed
the
jp/cloudflare-workers-e2e-span-streaming
branch
from
September 2, 2026 07:09
16e2bf2 to
867f31a
Compare
Lms24
reviewed
Sep 2, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
PR description says the streaming e2e test app is becoming the default but it seems like we're converting and renaming the streaming e2e test to static. Is this intentional?
Member
Author
The GitHub diffing seems to be a little off. In the renames you see that it's also changing it to |
Lms24
approved these changes
Sep 2, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
ahh thanks for explaining! yeah I think the diff just threw me off. makes sense 👍
…c copy Renames cloudflare-workers to cloudflare-workers-static, which stays on traceLifecycle: 'static' with the transaction-based specs, so the static trace lifecycle keeps E2E coverage. cloudflare-workers-streaming becomes the new cloudflare-workers and drops its explicit 'stream' pin, so the app exercises the default lifecycle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cloudflare-workers-e2e-span-streaming
branch
from
September 2, 2026 11:30
867f31a to
dcd3f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
cloudflare-workersto span streaming and keeps the static trace lifecycle covered, via two renames:cloudflare-workers→cloudflare-workers-static: verbatim, stays ontraceLifecycle: 'static'with the transaction-based specs. Only the app name changes (package.jsonname,proxyServerNameinstart-event-proxy.mjs, the proxy name in everywaitFor*call intests/, and the wrangler workername).cloudflare-workers-streaming→cloudflare-workers: same name changes, plus the explicittraceLifecycle: 'stream'pin is dropped so the app exercises the default lifecycle. Its basic-request test now also pins the segment name: the root path/is aroutesource, so the span keeps the fullGET /name under streaming.Renaming instead of copying keeps both apps' history followable and keeps the diff down to the name changes. Because the path
cloudflare-workersexists before and after, git pairs the rename as-streaming → -staticand showscloudflare-workersas modified; the file contents follow the two moves above.Side effect of the rename:
cloudflare-workersinherits the-streamingapp's active memory test (memory.test.ts, already running in CI for that app); the two skipped memory tests stay withcloudflare-workers-static.