Conversation
Contributor
size-limit report 📦
|
chargome
force-pushed
the
test/e2e-cachecomponents-streaming-parity
branch
from
September 1, 2026 14:33
3be9670 to
237d931
Compare
Member
|
Just wondering, does this test show what exactly is not working right now with cached components? |
…tic one `nextjs-16-streaming-cacheComponents` covered only 5 of the 9 tests its static counterpart runs. It was missing the two on-demand Server Component capture tests, the `generateMetadata` prerender test and the whole hanging promise rejection regression spec, along with the routes those need. Ports the missing tests over and adds the webpack variant. The hanging promise regression is only observable under webpack, because server components are wrapped by `wrappingLoader`, which Turbopack builds do not run, so without that variant the ported spec would never exercise it. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
test/e2e-cachecomponents-streaming-parity
branch
from
September 2, 2026 10:58
237d931 to
89558d7
Compare
Member
Author
|
@mydea not entirely no, because we accepted some drawbacks already that we need to find solutions for (like the ssr trace propagation) |
chargome
marked this pull request as ready for review
September 2, 2026 12:44
JPeer264
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
nextjs-16-streaming-cacheComponentsto parity withnextjs-16-cacheComponents: ports the 4 missing tests plus the routes they need, and adds the webpack variant.Ref #23802