ref(express)!: Export a single ExpressIntegrationOptions type - #23763
Merged
Merged
Conversation
s1gr1d
changed the title
This was referenced Aug 31, 2026
mydea
approved these changes
Aug 31, 2026
s1gr1d
force-pushed
the
sig/handle-error-type
branch
from
August 31, 2026 14:59
163fc2f to
46630d2
Compare
s1gr1d
force-pushed
the
sig/handle-error-type
branch
from
August 31, 2026 14:59
46630d2 to
5821de7
Compare
Contributor
size-limit report 📦
|
# Conflicts: # packages/core/src/server-exports.ts
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First merge this: #23732
Raised by @isaacs in this comment: https://github.com/getsentry/sentry-javascript/pull/23732/changes#r3890547157
ExpressIntegrationOptionswas exported publicly from two places under the same name. The one from@sentry/coreis deprecated and has noshouldHandleError.The one from
@sentry/server-utilshas it but was unreachable, because@sentry/nodere-exports neither. TypeScript users had no way to type ashouldHandleErrorcallback forexpressIntegration().