chore(repo): Add low cardinality span name setting skill - #23449
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
RulaKhaled
reviewed
Aug 18, 2026
RulaKhaled
left a comment
RulaKhaled
left a comment
Collaborator
There was a problem hiding this comment.
Looks solid. Left a question on the fallback examples (same static-route case as #23424) and a note on streamed e2e attribute assertions.
nicohrubec
approved these changes
Aug 24, 2026
Lms24
marked this pull request as ready for review
August 24, 2026 11:22
Lms24
force-pushed
the
lms/chore-span-name-low-card-skill
branch
from
August 24, 2026 11:22
36b7d9e to
143cc02
Compare
Lms24
enabled auto-merge (squash)
August 24, 2026 11:23
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| Read <https://getsentry.github.io/sentry-conventions/names/> and find the op. Each op lists attribute templates in priority order, ending in a static fallback — that fallback is your name. Examples: `pageload` → `Pageload`, `navigation` → `Navigation`, database ops → `Database operation`. | ||
|
|
||
| Add it next to `PAGELOAD_SPAN_NAME_FALLBACK` in `packages/core/src/spanNames.ts` and export it from `shared-exports.ts`. Every package imports it from `@sentry/core` directly — no re-export from `@sentry/browser` is needed. |
Contributor
There was a problem hiding this comment.
Bug: The SKILL.md file instructs the AI agent to modify a non-existent file, packages/core/src/spanNames.ts, instead of the correct file, packages/core/src/constants.ts.
Severity: MEDIUM
Suggested Fix
Update all references to packages/core/src/spanNames.ts within .agents/skills/port-span-names/SKILL.md to point to the correct file, packages/core/src/constants.ts.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .agents/skills/port-span-names/SKILL.md#L42
Potential issue: The `SKILL.md` file, which provides instructions for an AI agent,
contains multiple incorrect references to the file path
`packages/core/src/spanNames.ts`. This file does not exist in the codebase. The
instructions direct the agent to add a new constant next to
`PAGELOAD_SPAN_NAME_FALLBACK`, which is actually located in
`packages/core/src/constants.ts`. When this skill is used, the AI agent will likely fail
or generate code in the wrong location, creating an incorrect new file and leading to
inconsistencies and potential build issues.
Also affects:
.agents/skills/port-span-names/SKILL.md:14.agents/skills/port-span-names/SKILL.md:35
Did we get this right? 👍 / 👎 to inform future reviews.
JPeer264
pushed a commit
that referenced
this pull request
Aug 25, 2026
Adds a reusable skill to adjust span names to be low cardinality when span streaming is enabled. This can be used by anyone taking over one of the span op categories soon to be defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reusable skill to adjust span names to be low cardinality when span streaming is enabled. This can be used by anyone taking over one of the span op categories soon to be defined.