test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE by RulaKhaled · Pull Request #23367 · getsentry/sentry-javascript

RulaKhaled · 2026-08-12T13:48:28Z

Test updates for #23368. Merge this to land everything.

github-actions · 2026-08-12T14:04:33Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	28.57 kB	-0.01%	-1 B 🔽
@sentry/browser - with treeshaking flags	26.92 kB	+0.02%	+4 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing	26.82 kB	-0.02%	-5 B 🔽
@sentry/browser (incl. Tracing)	48.54 kB	+0.09%	+41 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)	48.56 kB	+0.07%	+33 B 🔺
@sentry/browser (incl. Tracing, Profiling)	51.47 kB	+0.08%	+40 B 🔺
@sentry/browser (incl. Tracing, Replay)	87.94 kB	+0.06%	+47 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	77.36 kB	+0.02%	+10 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	92.64 kB	+0.06%	+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	105.35 kB	+0.06%	+56 B 🔺
@sentry/browser (incl. Feedback)	45.81 kB	-0.01%	-3 B 🔽
@sentry/browser (incl. sendFeedback)	33.36 kB	-	-
@sentry/browser (incl. FeedbackAsync)	38.46 kB	-0.03%	-8 B 🔽
@sentry/browser (incl. Metrics)	29.51 kB	-0.04%	-11 B 🔽
@sentry/browser (incl. Logs)	29.8 kB	+0.02%	+3 B 🔺
@sentry/browser (incl. Metrics & Logs)	30.43 kB	-0.07%	-19 B 🔽
@sentry/react	30.31 kB	-0.08%	-24 B 🔽
@sentry/react (incl. Tracing)	50.75 kB	+0.09%	+41 B 🔺
@sentry/vue	35.69 kB	+0.15%	+50 B 🔺
@sentry/vue (incl. Tracing)	50.77 kB	+0.07%	+31 B 🔺
@sentry/svelte	28.59 kB	-0.04%	-9 B 🔽
CDN Bundle	30.36 kB	+0.14%	+40 B 🔺
CDN Bundle (incl. Tracing)	49.01 kB	-0.03%	-13 B 🔽
CDN Bundle (incl. Logs, Metrics)	32.56 kB	+0.08%	+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	50.9 kB	+0.02%	+7 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	72.92 kB	+0.03%	+20 B 🔺
CDN Bundle (incl. Tracing, Replay)	86.45 kB	-0.02%	-11 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	88.34 kB	+0.02%	+9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	92.24 kB	+0.02%	+13 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	94.16 kB	-0.01%	-8 B 🔽
CDN Bundle - uncompressed	89.97 kB	+0.04%	+29 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	146.64 kB	+0.01%	+2 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	96.26 kB	+0.04%	+29 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	152.33 kB	+0.01%	+2 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	225.23 kB	+0.03%	+55 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	265.95 kB	+0.02%	+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	271.62 kB	+0.02%	+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	279.64 kB	+0.02%	+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	285.31 kB	+0.01%	+28 B 🔺
@sentry/nextjs (client)	53.3 kB	+0.13%	+68 B 🔺
@sentry/sveltekit (client)	48.96 kB	+0.09%	+44 B 🔺
@sentry/core/server	65.19 kB	+0.13%	+81 B 🔺
@sentry/core/browser	52.34 kB	+0.13%	+67 B 🔺
@sentry/node	121.61 kB	+0.14%	+161 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	85.18 kB	-	-
@sentry/node - without tracing	87.6 kB	+0.2%	+169 B 🔺
@sentry/aws-serverless	96.04 kB	+0.22%	+206 B 🔺
@sentry/cloudflare (withSentry) - minified	197.1 kB	+0.11%	+207 B 🔺
@sentry/cloudflare (withSentry)	487.48 kB	+0.01%	+6 B 🔺

View base workflow run

RulaKhaled · 2026-08-24T11:52:34Z

Re-opening to refresh mergeability after squashing/rebasing the stacked base (GitHub still reports dirty despite a clean fast-forward).

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2b4e8dd. Configure here.}

JPeer264

LGTM. We should also update the semantic conventions to match the new behavior (not sure if that is already being worked on): https://getsentry.github.io/sentry-conventions/attributes/sentry/#sentry-source

RulaKhaled · 2026-08-25T09:36:58Z

LGTM. We should also update the semantic conventions to match the new behavior (not sure if that is already being worked on): https://getsentry.github.io/sentry-conventions/attributes/sentry/#sentry-source

i'll add it to my todos for the day!

Align unit and E2E tests with segment-only sentry.segment.name.source. Fixes #22259 Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

… HTTP test Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

….name.source

…Span tests Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

…nto feat/segment-name-source-tests

Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

Besides removing SEMANTIC_ATTRIBUTE_SENTRY_SOURCE and using SENTRY_SEGMENT_NAME_SOURCE instead, this PR also: * Sets name source only on segment spans (per the [Sentry segment name source convention](<https://develop.sentry.dev/sdk/telemetry/attributes/#sentrysegmentnamesource>)) — e.g. updateName, HTTP server spans, and tRPC when it is the segment root * Removes envelope-time backfill from sentry.source → sentry.segment.name.source in captureSpan CI note: This PR alone is expected to fail CI. It will stay blocked until [#23367](<#23367>) is merged into it — that split is intentional to keep the core changes easier to review. Fixes #22259 --------- Co-authored-by: Cursor Grok 4.6 <cursoragent@cursor.com>

RulaKhaled force-pushed the feat/segment-name-source-tests branch from 41f0162 to 2facc03 Compare August 12, 2026 13:56

RulaKhaled mentioned this pull request Aug 12, 2026

ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE #23368

Merged

RulaKhaled force-pushed the feat/segment-name-source-tests branch 6 times, most recently from da8494e to 21a8801 Compare August 12, 2026 16:03

RulaKhaled changed the title ~~test: Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE~~ test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE Aug 12, 2026

RulaKhaled force-pushed the feat/segment-name-source-tests branch 2 times, most recently from 095645a to a9eb1f6 Compare August 13, 2026 09:20

RulaKhaled force-pushed the feat/segment-name-source-tests branch from a9eb1f6 to b586685 Compare August 13, 2026 09:22

RulaKhaled force-pushed the feat/segment-name-source-tests branch 2 times, most recently from 3746240 to 114d12f Compare August 17, 2026 18:17

RulaKhaled self-assigned this Aug 24, 2026

RulaKhaled force-pushed the feat/segment-name-source-tests branch 3 times, most recently from f386f68 to 875cfd1 Compare August 24, 2026 11:40

RulaKhaled force-pushed the feat/segment-name-source-tests branch from 875cfd1 to e9b3e1a Compare August 24, 2026 11:50

RulaKhaled closed this Aug 24, 2026

RulaKhaled reopened this Aug 24, 2026

RulaKhaled requested review from a team as code owners August 24, 2026 12:12

RulaKhaled requested review from JPeer264, chargome, isaacs, logaretm, msonnb and nicohrubec and removed request for a team August 24, 2026 12:12

cursor Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread dev-packages/e2e-tests/test-applications/deno-streamed/tests/spans.test.ts

RulaKhaled force-pushed the feat/segment-name-source-tests branch from 72db291 to d717059 Compare August 24, 2026 16:22

sentry Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread packages/core/test/lib/tracing/spans/captureSpan.test.ts

s1gr1d approved these changes Aug 25, 2026

View reviewed changes

JPeer264 approved these changes Aug 25, 2026

View reviewed changes

RulaKhaled and others added 5 commits August 25, 2026 11:45

test: Update assertions for SENTRY_SEGMENT_NAME_SOURCE

364f1b2

Align unit and E2E tests with segment-only sentry.segment.name.source. Fixes #22259 Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

test(deno): Drop duplicate sentry.segment.name.source assertion

1c8f603

test: Drop duplicate sentry.segment.name.source assertion in streamed…

6c07c4f

… HTTP test Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

test(browser-utils): Assert inherited route source via sentry.segment…

da850f0

….name.source

test(core): Drop duplicate sentry.segment.name.source keys in capture…

bdae8d9

…Span tests Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

RulaKhaled force-pushed the feat/segment-name-source-tests branch from 3f3e342 to bdae8d9 Compare August 25, 2026 09:45

RulaKhaled and others added 4 commits August 25, 2026 13:40

Merge remote-tracking branch 'origin/feat/segment-name-source-impl' i…

5f61561

…nto feat/segment-name-source-tests

Merge remote-tracking branch 'origin/feat/segment-name-source-impl' i…

fd88105

…nto feat/segment-name-source-tests

Merge remote-tracking branch 'origin/feat/segment-name-source-impl' i…

5a15662

…nto feat/segment-name-source-tests

chore(core): Format child-span name-source warning

56c37cf

Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>

RulaKhaled merged commit 64a0de2 into develop Aug 25, 2026
274 checks passed

RulaKhaled deleted the feat/segment-name-source-tests branch August 25, 2026 12:32

Navigation Menu

Uh oh!

test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE - #23367

test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE#23367
RulaKhaled merged 9 commits into
feat/segment-name-source-implfrom
feat/segment-name-source-tests

RulaKhaled commented Aug 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

RulaKhaled commented Aug 24, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

JPeer264 left a comment

Uh oh!

RulaKhaled commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

RulaKhaled commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

RulaKhaled commented Aug 24, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

RulaKhaled commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RulaKhaled commented Aug 12, 2026 •

edited

Loading

github-actions Bot commented Aug 12, 2026 •

edited

Loading