fix(react-router): Use react-router's own instrumentation types instead of a mirrored copy - #23310
Merged
Merged
Conversation
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85f2783. Configure here.
logaretm
marked this pull request as ready for review
August 11, 2026 19:12
logaretm
requested review from
chargome and
s1gr1d
and removed request for
a team
August 11, 2026 19:12
Contributor
2 similar comments
Contributor
Contributor
s1gr1d
approved these changes
Aug 24, 2026
logaretm
force-pushed
the
awad/react-router-instrumentation-types-drift
branch
from
August 24, 2026 15:17
85f2783 to
6903c9c
Compare
…ad of a mirrored copy
logaretm
force-pushed
the
awad/react-router-instrumentation-types-drift
branch
from
August 24, 2026 17:07
6903c9c to
27d52a1
Compare
JPeer264
pushed a commit
that referenced
this pull request
Aug 25, 2026
…ad of a mirrored copy (#23310) Types `createSentryServerInstrumentation()` / `createSentryClientInstrumentation()` against react-router's own exported `ServerInstrumentation` / `ClientInstrumentation` types instead of a hand-maintained mirror that had drifted. The vendored types were internal-only, so deleting it isn't a public API change, and runtime should be unaffected. closes #23265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
createSentryServerInstrumentation()/createSentryClientInstrumentation()against react-router's own exportedServerInstrumentation/ClientInstrumentationtypes instead of a hand-maintained mirror that had drifted.The vendored types were internal-only, so deleting it isn't a public API change, and runtime should be unaffected.
closes #23265