Repository navigation
build(samples): [Sample Tests 48] Move the JVM samples to their own build - #6394
Draft
runningcode wants to merge 1 commit into
Draft
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
This was referenced Oct 27, 2026
Draft
📲 Install BuildsAndroid
|
runningcode
force-pushed
the
no/android-integration-tests-own-build
branch
from
October 27, 2026 14:33
04f1683 to
7771435
Compare
runningcode
force-pushed
the
no/jvm-samples-own-build
branch
from
October 27, 2026 14:33
25775a4 to
02f2246
Compare
The 28 JVM samples are now a standalone Gradle build in sentry-samples that includes the SDK build, like the Android sample and the Android integration tests. They depend on io.sentry:* coordinates, which Gradle substitutes with the SDK's projects. The SDK build doesn't include them back, so the Spring Boot, gretty and shadow plugins the samples apply no longer load in the SDK build. The three bootRunWithAgent tasks find the agent jar from the repository root and take the SDK version from the catalog, since the samples build has its own root directory and gradle.properties. With no samples or integration tests left in the SDK build, its apiValidation list and the name filters that skipped them for publishing and CodeQL go too. Root check and spotlessApply no longer reach the samples, so preMerge runs this build's check, which covers what the root check ran for them: compilation, jars and spotless. The format workflow runs its spotlessApply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/jvm-samples-own-build
branch
from
October 27, 2026 15:08
02f2246 to
c78db42
Compare
runningcode
force-pushed
the
no/android-integration-tests-own-build
branch
from
October 27, 2026 15:08
7771435 to
76332ce
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
The 28 JVM samples are now a standalone Gradle build in
sentry-samplesthat includes the SDK build, like the Android sample and the Android integration tests. They depend onio.sentry:*coordinates, which Gradle substitutes with the SDK's projects. The SDK build doesn't include them back, so the Spring Boot, gretty and shadow plugins the samples apply no longer load in it.sentry-samples-androidstays a separate build of its own.Run it with
./gradlew -p sentry-samples <task>.build.gradle.ktsappliesio.sentry.spotlessandio.sentry.jdk-targetto every sample, as the SDK build's root did. The Spring Boot plugin stays in each sample, because the samples use different versions of it.bootRunWithAgent: the three tasks find the agent jar from the repository root and take the SDK version from the catalog.apiValidationlist keeps onlysentry-test-support. The name filters that skipped samples and integration tests for publishing and CodeQL go too.AGENTS.mdand thenew_modulerule describe the separate builds.make preMergeruns this build'scheck, and the format workflow andmake checkFormatcover it.💡 Motivation and Context
Part of the Linear project "Separate sample projects and tests from build." (JAVA-626): untie the SDK build from the versions used to test.
💚 How did you test it?
checkpasses and runs what the rootcheckran for the samples: 28compileJava, 20compileKotlin, 20jar, 5shadowJarand 28spotlessCheck.io.sentry:*coordinate is checked against the SDK's project names. Typesafe accessors drop the hyphen before a digit, sosentrySpring7issentry-spring-7.checkpasses.buildForCodeQLand rootcheck --dry-runpass.spotlessApply apiDumpchanges nothing.bootRunWithAgent.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
make preMergenow runs three more Gradle invocations in the required Build job, and each configures the SDK build again. The added CI time hasn't been measured yet.Decoupling AGP from the SDK build needs the build-local Maven repo (JAVA-625).
This is the last PR in the stack.
#skip-changelog
🤖 Generated with Claude Code