Conversation
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
August 31, 2026 10:50
c51544f to
a2b75f9
Compare
giortzisg
marked this pull request as ready for review
August 31, 2026 10:52
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 1, 2026 09:13
a2b75f9 to
603e3a2
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 1, 2026 12:22
603e3a2 to
71174c7
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 1, 2026 12:58
71174c7 to
630a26a
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 2, 2026 07:59
630a26a to
7efce58
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 4, 2026 13:12
7efce58 to
204d3b1
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 4, 2026 13:26
204d3b1 to
545a30d
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 7, 2026 11:40
545a30d to
e6596b7
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 7, 2026 11:50
e6596b7 to
fe5ae57
Compare
szokeasaurusrex
approved these changes
Sep 10, 2026
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Again some questions but seems reasonable
Comment on lines
67
to
70
| if storedCtx, ok := ctx.UserValue(contextKey{}).(*storedContext); ok { | ||
| storedCtx.cancel() | ||
| parentCtx = context.Background() | ||
| } |
Member
There was a problem hiding this comment.
[question] What is a storedContext and why is it needed for FastHTTP? I did not see anything similar in the other HTTP frameworks.
| func TestSetHubOnContext(t *testing.T) { | ||
| hub := sentry.NewHub(sentry.CurrentHub().Client(), sentry.NewScope()) | ||
| ctx := &fasthttp.RequestCtx{} | ||
| func TestRequestIsolation(t *testing.T) { |
Member
There was a problem hiding this comment.
[question] I am just wondering why we added this test here, for fasthttp, and not for the other HTTP frameworks in the previous PRs?
The test does also seem quite complex, and it seems we implemented similar tests in fiber and fiberv3 also, so I wonder if we could extract the common logic somehow and/or simplify it a bit
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 16, 2026 09:14
fe5ae57 to
798d05b
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 17, 2026 08:38
798d05b to
6259c50
Compare
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 17, 2026 09:09
6259c50 to
6107215
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6107215. Configure here.
Carry isolated scopes through native Fiber contexts and an explicit FastHTTP context bridge, including the framework error-handler lifecycle. Preserve active caller traces and let only the transaction creator update or finish them. Keep outer request cleanup registered across nested wrappers, distinguish active FastHTTP nesting from pooled request reuse, and read all incoming baggage values. Fiber v2, Fiber v3, and FastHTTP GetHubFromContext, SetHubOnContext, and GetSpanFromContext helpers are removed. Use the integrations' GetContext helpers and the root sentry context accessors, plus FastHTTP SetContext when supplying a parent context.
giortzisg
removed this pull request from stack #1420
September 18, 2026 11:17
giortzisg
force-pushed
the
scopes/fiber-fasthttp-integrations
branch
from
September 18, 2026 11:18
6107215 to
e91a65d
Compare
giortzisg
added this pull request to stack #1433
September 18, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates fasthttp frameworks to the new scopes API
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)