feat: add trace methods to public API by giortzisg · Pull Request #1394 · getsentry/sentry-go

giortzisg · 2026-08-24T10:18:17Z

Description

This adds new trace propagation APIs that resolve with context. Also changes logs and metrics to resolve scope through context rather than the old hub API.

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

Single entry: just write text
Multiple entries: use bullet points
Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Add GH Issue ID & Linear ID
PR title should use conventional commit style (feat:, fix:, ref:, meta:)
For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

cursor

Stale Bugbot comment from a previous run.

szokeasaurusrex

The changes mostly look okay, ~~but it seems this PR contains more changes than are suggested by the PR description. Was there perhaps a problem when rebasing the stack? Or these are all intended to be here?~~

Edit: Nvm, I re-read the description and suppose everything is in scope 😅

szokeasaurusrex · 2026-09-08T11:10:12Z

What was this file's purpose? Was it for enable_logs == false?

szokeasaurusrex · 2026-09-08T11:12:01Z

+type panicStringer struct{}
+
+func (panicStringer) String() string {
+	panic("disabled logs must not format values")
+}
+
+// flushFromContext flushes the client from the given context.
 func flushFromContext(ctx context.Context, timeout time.Duration) {
-	hub := GetHubFromContext(ctx)
-	if hub == nil {
-		hub = CurrentHub()
-	}
-	hub.Flush(timeout)
+	ClientFromContext(ctx).Flush(timeout)
+}
+
+func TestDisabledLoggerDoesNotFormatValues(_ *testing.T) {
+	ctx := ContextWithClient(context.Background(), NewNoopClient())
+	logger := NewLogger(ctx)
+
+	logger.Info().Emit(panicStringer{})
+	logger.Info().Emitf("%v", panicStringer{})


szokeasaurusrex · 2026-09-08T11:14:46Z

+	fallbackCtx := m.fallbackCtx
+	scope := ScopeFromContext(ctx)
+	if scope == nil {
+		scope = ScopeFromContext(fallbackCtx)
+	} else {
+		fallbackCtx = nil
+	}
+	if options.scope != nil {
+		scope = options.scope
 	}


l: It looks like we had similar logic in log.go. Perhaps we can extract it into a function?

szokeasaurusrex · 2026-09-08T11:19:23Z

+	setString("sentry.release", client.options.Release)
+	setString("sentry.environment", client.options.Environment)
+	setString("sentry.server.address", serverAddress)
+	setString("sentry.sdk.name", sdkName)
+	setString("sentry.sdk.version", client.sdkVersion)
+	setString("user.id", scope.user.ID)
+	setString("user.name", scope.user.Name)
+	setString("user.email", scope.user.Email)


m: It would probably be a good idea to extract these attribute names into constants rather than hardcoding them

Resolve log, metric, and propagation data from context-backed clients and scopes, and expose context-based trace header helpers while retaining Hub compatibility. Use the request transaction as the scope fallback, preserve external trace precedence and sampling flags, and propagate only matching dynamic sampling context. Freeze spanless scope metadata once on first export and take trace IDs and DSC from the same locked snapshot. Reject frozen custom metadata for another trace and propagate a negative decision for fresh unsampled scope-only traces. Explicit request scopes, including metric overrides, isolate logger and meter trace fallback. Replace stale Sentry baggage while preserving outgoing third-party members. Keep malformed baggage errors visible to direct parser callers while continuing valid sentry-trace headers. Preserve head sampling metadata when a late status filter rejects a transaction.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7c1e40f. Configure here.}

cursor · 2026-09-18T11:28:00Z

 		return span.ToBaggage()
 	}
-	return scope.propagationContextSnapshot().DynamicSamplingContext.String()
+	return scope.propagationContextForPropagation(hub.Client()).DynamicSamplingContext.String()


Hub trace headers disagree on sampling

Medium Severity

GetBaggage now applies the static zero-rate decision and writes sampled=false into DSC, but GetTraceparent and GetTraceparentW3C still read the unsampled snapshot. Callers that emit the sentry-trace header first, including the documented Hub pairing, send a deferred sampling flag while baggage already says the trace is unsampled.

Additional Locations (1)

hub.go#L392-L411

^{Reviewed by Cursor Bugbot for commit 7c1e40f. Configure here.}

giortzisg force-pushed the scopes/integration-primitives branch from 4d788fd to deeab0c Compare August 24, 2026 10:53

giortzisg marked this pull request as ready for review August 24, 2026 13:24

cursor Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread scope.go

giortzisg requested review from sl0thentr0py and szokeasaurusrex August 31, 2026 07:48

giortzisg force-pushed the scopes/integration-primitives branch from deeab0c to 7e6baff Compare August 31, 2026 10:50

sentry Bot reviewed Aug 31, 2026

View reviewed changes

Comment thread metrics.go Outdated

cursor Bot reviewed Aug 31, 2026

View reviewed changes

Comment thread log.go

giortzisg force-pushed the scopes/integration-primitives branch from 7e6baff to 51c535e Compare September 1, 2026 09:12

cursor Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread log.go Outdated

giortzisg requested a review from Litarnus September 1, 2026 09:19

giortzisg force-pushed the scopes/integration-primitives branch from 51c535e to d7b1f55 Compare September 1, 2026 12:57

giortzisg force-pushed the scopes/integration-primitives branch from d7b1f55 to 45876fc Compare September 2, 2026 07:59

giortzisg force-pushed the scopes/integration-primitives branch from 45876fc to 71754bd Compare September 4, 2026 13:11

sentry Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread tracing.go Outdated

giortzisg force-pushed the scopes/integration-primitives branch from 71754bd to 4ec37b3 Compare September 4, 2026 13:26

sentry Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread tracing.go Outdated

giortzisg force-pushed the scopes/integration-primitives branch from 4ec37b3 to c4e83dd Compare September 7, 2026 11:40

sentry Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread tracing.go Outdated

giortzisg force-pushed the scopes/integration-primitives branch from c4e83dd to c2a58ea Compare September 7, 2026 11:49

szokeasaurusrex reviewed Sep 8, 2026

View reviewed changes

giortzisg force-pushed the scopes/integration-primitives branch from c2a58ea to aeb2126 Compare September 16, 2026 09:14

sentry Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread metrics.go Outdated

giortzisg force-pushed the scopes/integration-primitives branch from aeb2126 to 3da3e78 Compare September 17, 2026 08:38

sentry Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread dynamic_sampling_context.go

giortzisg force-pushed the scopes/integration-primitives branch from 3da3e78 to a5ded29 Compare September 17, 2026 09:09

giortzisg removed this pull request from stack #1420 September 18, 2026 11:17

giortzisg force-pushed the scopes/integration-primitives branch from a5ded29 to 7c1e40f Compare September 18, 2026 11:18

giortzisg added this pull request to stack #1433 September 18, 2026 11:22

cursor Bot reviewed Sep 18, 2026

View reviewed changes

Navigation Menu

feat: add trace methods to public API - #1394

feat: add trace methods to public API#1394
giortzisg wants to merge 1 commit into
scopes/context-tracingfrom
scopes/integration-primitives

giortzisg commented Aug 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex left a comment •

edited

Loading

Uh oh!

szokeasaurusrex Sep 8, 2026

Uh oh!

szokeasaurusrex Sep 8, 2026

Uh oh!

szokeasaurusrex Sep 8, 2026

Uh oh!

szokeasaurusrex Sep 8, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

giortzisg commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szokeasaurusrex Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

szokeasaurusrex Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

szokeasaurusrex Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

szokeasaurusrex Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Sep 18, 2026

Choose a reason for hiding this comment

Hub trace headers disagree on sampling

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

giortzisg commented Aug 24, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

szokeasaurusrex left a comment •

edited

Loading