Conversation
giortzisg
marked this pull request as ready for review
July 30, 2026 19:04
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
July 30, 2026 20:45
e509cb6 to
5ea0d02
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
July 30, 2026 20:45
efccd51 to
c6716f7
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 4, 2026 15:25
5ea0d02 to
2905cce
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 4, 2026 15:25
c6716f7 to
5af8a98
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 4, 2026 15:42
2905cce to
8b46a73
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 4, 2026 15:42
5af8a98 to
de7d759
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 5, 2026 09:59
8b46a73 to
b3bd79f
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 5, 2026 09:59
de7d759 to
545c0ef
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 10, 2026 11:28
b3bd79f to
5ab473f
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 10, 2026 11:28
545c0ef to
4997f79
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 10, 2026 11:36
5ab473f to
a27e5e5
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 10, 2026 11:36
4997f79 to
180fcc5
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
5 times, most recently
from
August 13, 2026 12:51
2e3f4c5 to
bf26935
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
2 times, most recently
from
August 13, 2026 12:54
26a5f90 to
148a75b
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 24, 2026 10:17
bf26935 to
ec3c9a6
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 24, 2026 10:17
148a75b to
066ed7c
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
August 31, 2026 10:50
ec3c9a6 to
503b67b
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
August 31, 2026 10:50
066ed7c to
6cf3963
Compare
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
In general the changes look good to me (though I am also not super familiar with everything being changed).
The one point that is unclear to me is what the context itself is meant to do, as the linked issues do not really describe it.
Is the new API documented somewhere in more detail? If yes, please link, if not, let's discuss it.
| return client.CaptureException(err, opts.hint, scope) | ||
| } | ||
|
|
||
| func (client *Client) processEvent(event *Event, scope *Scope, opts captureOptions) (*EventID, bool) { |
Member
There was a problem hiding this comment.
l: What does the bool indicate here?
I think it would be worth adding a documentation comment to explain what the bool means
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 1, 2026 09:12
503b67b to
24d5a46
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
September 1, 2026 09:12
6cf3963 to
8f3aec5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f3aec5. Configure here.
This PR changes the client boundaries so that we always return a non nil client.
This PR makes it easier to clear the current scope, by just
initializing
a new scopeData field
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 1, 2026 12:57
24d5a46 to
ff67282
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
September 1, 2026 12:57
8f3aec5 to
709abf4
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 2, 2026 07:58
ff67282 to
c7f455b
Compare
giortzisg
force-pushed
the
scopes/context-capture
branch
from
September 2, 2026 07:58
709abf4 to
1bf4b1d
Compare
giortzisg
force-pushed
the
scopes/scope-merge
branch
from
September 4, 2026 13:11
c7f455b to
a7e13ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)