Skip to content

feat!: add noop client implementation - #1365

Open
giortzisg wants to merge 1 commit into
scopes/go127-lintfrom
scopes/noop-client
Open

giortzisg wants to merge 1 commit into
scopes/go127-lintfrom
scopes/noop-client

Conversation

@giortzisg

@giortzisg giortzisg commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

This adds the Client interface and noop and default client implementations for the SDK. This better aligns the behavior with the current client spec and removes the need to always nil check any client.

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Changelog Entry

  • add NoopClient implementation. The SDK now returns a non-nil noop client and handles the previous nil checks with checking for a disabled client.

@giortzisg
giortzisg changed the base branch from feat/scopes to master July 20, 2026 08:33
@linear-code

linear-code Bot commented Jul 20, 2026

Copy link
Copy Markdown

GO-153

@giortzisg
giortzisg marked this pull request as ready for review July 20, 2026 11:24
Comment thread httpclient/sentryhttpclient.go Outdated
@giortzisg
giortzisg changed the base branch from master to feat/scopes July 21, 2026 12:36
@giortzisg
giortzisg force-pushed the scopes/noop-client branch from 4337b6c to 415d82c Compare July 23, 2026 08:45
Comment thread client.go Outdated
@giortzisg
giortzisg force-pushed the scopes/noop-client branch from 415d82c to 18b7a4a Compare July 30, 2026 20:45
Comment thread client_api.go Outdated
@giortzisg
giortzisg changed the base branch from feat/scopes to master August 10, 2026 11:30
@giortzisg
giortzisg force-pushed the scopes/noop-client branch 2 times, most recently from 59c6bdc to 095e3a7 Compare August 10, 2026 11:57
Comment thread client_api.go Outdated
Comment thread hub.go
Comment thread client.go
Comment thread client.go Outdated
Comment thread hub.go Outdated
@giortzisg giortzisg changed the title feat: add noop client implementation feat!: add noop client implementation Sep 1, 2026
Comment thread hub.go Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fcd9962. Configure here.

Comment thread hub.go
@giortzisg
giortzisg changed the base branch from master to scopes/go127-lint September 4, 2026 13:11
Comment thread client.go
@giortzisg
giortzisg removed this pull request from stack #1420 September 18, 2026 11:17
@giortzisg
giortzisg added this pull request to stack #1433 September 18, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize noop client prerequisite

2 participants