fix(callbacks): wrap Oban callbacks - #1224
Merged
solnic merged 8 commits intoSep 23, 2026
Merged
Conversation
solnic
added this pull request to stack #1225
September 22, 2026 07:48
solnic
force-pushed
the
fix/wrap-oban-callbacks
branch
from
September 22, 2026 08:28
511815d to
22576dc
Compare
solnic
marked this pull request as ready for review
September 22, 2026 09:14
solnic
force-pushed
the
fix/wrap-oban-callbacks
branch
2 times, most recently
from
September 22, 2026 10:06
57d52d8 to
f4d5908
Compare
solnic
force-pushed
the
fix/wrap-oban-callbacks
branch
from
September 23, 2026 14:43
f4d5908 to
73a28dd
Compare
sl0thentr0py
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the Oban job exception and cron check-in telemetry handlers run through
Sentry.Callback.guard/3. A crash is logged as anerrorwith:sentrylog domain and goes out as a client report with theinternal_sdk_errorreason, and the telemetry handler stays attached — before this, one bad callback made:telemetrydetach the handler and silently ended all Oban error reporting and check-ins for the lifetime of the node.Each callback then degrades on its own terms:
should_report_error_callbackandshould_report_error_check_in_callbackare treated as if they returnedtruemonitor_slug_generatorfalls back to the slug derived from the worker namesentry_check_in_configurationis skipped so the check-in is sent with the options the integration inferredoban_tags_to_sentry_tagsleaves the event with the integration's own tags (a non-map return is logged as awarningand does the same).Logging potential crashes is also consolidated now.