Skip to content

fix(callbacks): wrap Oban callbacks - #1224

Merged
solnic merged 8 commits into
fix/wrap-plug-and-phoenix-callbacksfrom
fix/wrap-oban-callbacks
Sep 23, 2026
Merged

solnic merged 8 commits into
fix/wrap-plug-and-phoenix-callbacksfrom
fix/wrap-oban-callbacks

Conversation

@solnic

@solnic solnic commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Now the Oban job exception and cron check-in telemetry handlers run through Sentry.Callback.guard/3. A crash is logged as an error with :sentry log domain and goes out as a client report with the internal_sdk_error reason, and the telemetry handler stays attached — before this, one bad callback made :telemetry detach the handler and silently ended all Oban error reporting and check-ins for the lifetime of the node.

Each callback then degrades on its own terms:

  • should_report_error_callback and should_report_error_check_in_callback are treated as if they returned true
  • monitor_slug_generator falls back to the slug derived from the worker name
  • sentry_check_in_configuration is skipped so the check-in is sent with the options the integration inferred
  • oban_tags_to_sentry_tags leaves the event with the integration's own tags (a non-map return is logged as a warning and does the same).

Logging potential crashes is also consolidated now.

@solnic
solnic added this pull request to stack #1225 September 22, 2026 07:48
@solnic solnic changed the title Fix/wrap oban callbacks fix(callbacks): wrap Oban callbacks Sep 22, 2026
@solnic
solnic force-pushed the fix/wrap-oban-callbacks branch from 511815d to 22576dc Compare September 22, 2026 08:28
@solnic
solnic marked this pull request as ready for review September 22, 2026 09:14
@solnic
solnic force-pushed the fix/wrap-oban-callbacks branch 2 times, most recently from 57d52d8 to f4d5908 Compare September 22, 2026 10:06
@solnic
solnic force-pushed the fix/wrap-oban-callbacks branch from f4d5908 to 73a28dd Compare September 23, 2026 14:43
@solnic
solnic merged commit 519c2b4 into master Sep 23, 2026
16 checks passed
@solnic
solnic deleted the fix/wrap-oban-callbacks branch September 23, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants