fix(callbacks): wrap traces sampler callback - #1222
Merged
solnic merged 4 commits intoSep 23, 2026
Merged
Conversation
solnic
added this pull request to stack #1225
September 22, 2026 07:48
solnic
changed the title
solnic
marked this pull request as ready for review
September 22, 2026 09:03
solnic
force-pushed
the
fix/wrap-traces-sampler-callback
branch
from
September 22, 2026 10:06
81133cf to
8c70dc2
Compare
solnic
force-pushed
the
fix/wrap-traces-sampler-callback
branch
from
September 23, 2026 14:43
8c70dc2 to
f6f80b2
Compare
sl0thentr0py
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
traces_samplerruns viaSentry.Callbackand any crash is handled and logged aserrorwith:sentrylog domain AND that falls back to usingtraces_sample_rateassuming it's set, if it's not then we send client report withcallback_errorset as the reason.