fix: Honour enabled: false for envelopes forwarded from renderers and utility processes - #1432
Merged
Merged
Conversation
… utility processes Main sent renderer spans, replay, profile chunks and utility process non-event envelopes straight to the transport, which skips the client's enabled check. Send them through client.sendEnvelope instead.
timfish
enabled auto-merge (squash)
September 17, 2026 14:18
JPeer264
approved these changes
Sep 17, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the main process is initialised with
enabled: false, events from renderers are dropped because they go throughcaptureEvent. Spans, replay and profile chunk envelopes from renderers, and non-event envelopes from utility processes, were still sent. Main forwarded them withgetClient()?.getTransport()?.send(envelope), which skips the client's enabled check.This sends them through
client.sendEnvelopeinstead. It checksenabledand the transport, and resolves{}when it does not send. It also emitsbeforeEnvelope; both listeners in main (normalizePaths,rendererProfiling) ignore these envelope types, so nothing else changes.Adds an e2e test app with
enabled: falsein main and replay plus tracing in the renderer. It fails without this change and passes with it.Found while reviewing #1429, which works around the same problem with its own
enabledchecks.