Skip to content

feat: NLog target no longer initializes the SDK - #5585

Draft
jamescrosswell wants to merge 3 commits into
feat/no-init-from-logging-5245from
feat/no-init-from-logging-nlog-5245
Draft

jamescrosswell wants to merge 3 commits into
feat/no-init-from-logging-5245from
feat/no-init-from-logging-nlog-5245

feat: NLog target flushes using the SDK's FlushTimeout

489d7ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2026 in 1s

74.58% (-0.09%) compared to c72c26e

View this Pull Request on Codecov

74.58% (-0.09%) compared to c72c26e

Details

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.58%. Comparing base (c72c26e) to head (489d7ce).

Files with missing lines Patch % Lines
src/Sentry.NLog/SentryTarget.cs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/no-init-from-logging-5245    #5585      +/-   ##
==================================================================
- Coverage                           74.67%   74.58%   -0.09%     
==================================================================
  Files                                 515      514       -1     
  Lines                               18834    18745      -89     
  Branches                             3667     3646      -21     
==================================================================
- Hits                                14064    13981      -83     
+ Misses                               3893     3891       -2     
+ Partials                              877      873       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.