Skip to content

Make Scope.Environment non nullable (next major) #5388

Description

@jamescrosswell

As of #5365, Scope.Environment can't be null:

if (value is null)
{
Options.LogDebug("Environment cannot be null. Reverting to default value from the options.");
field = Options.Environment;
}

We may as well reflect that in the property declaration (which is currently string?).

Note

Breaking change so will need to wait till next major

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

.NETPull requests that update .net codeBreaking ChangeBinary/Source/Behavioral Breaking Changes.ImprovementNext MajorChanges scheduled for the next Major release.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions