-
-
Notifications
You must be signed in to change notification settings - Fork 250
Make Scope.Environment non nullable (next major) #5388
Copy link
Copy link
Open
Labels
.NETPull requests that update .net codePull requests that update .net codeBreaking ChangeBinary/Source/Behavioral Breaking Changes.Binary/Source/Behavioral Breaking Changes.ImprovementNext MajorChanges scheduled for the next Major release.Changes scheduled for the next Major release.
Description
Activity
Metadata
Metadata
Assignees
Labels
.NETPull requests that update .net codePull requests that update .net codeBreaking ChangeBinary/Source/Behavioral Breaking Changes.Binary/Source/Behavioral Breaking Changes.ImprovementNext MajorChanges scheduled for the next Major release.Changes scheduled for the next Major release.
As of #5365, Scope.Environment can't be null:
sentry-dotnet/src/Sentry/Scope.cs
Lines 158 to 162 in b7dd7fb
We may as well reflect that in the property declaration (which is currently
string?).Note
Breaking change so will need to wait till next major