fix(docs): Remove stale JS logs loader warning#18387
Open
macuzi wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17124 where the
/platforms/javascript/logs/page still showed a warning saying:That guidance appears to be outdated, As the loader/CDN bundles with logs support according to this comment
Support Sentry Logging in the JS Loader and CDN · Issue #16314 · getsentry/sentry-javascript
This will remove the stale warning and replace pointing to the Loader Script docs.
Capacitor was left unchanged on purpose. Since it uses javascript.capacitor.mdx, and the stale warning there is wrapped in
<PlatformSection supported={["javascript"]}>, so it does not render on Capacitor pages since it's checking for:not
It’s gated by the wrong key for that page. But I think that's by design, should be safe to leave that file alone for now.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.