Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ed996d. Configure here.
Lms24
marked this pull request as ready for review
September 10, 2026 14:48
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 10, 2026 14:48
buenaflor
approved these changes
Sep 10, 2026
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
lgtm, I don't have a strong opinion on the naming but given the constraints I think it is the "lesser evil" like you described
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Today, all/most of our
url,serverorhttpattributes are interchangeably used to describe incoming and outgoing requests. This is (mostly) in line with OTel's definition. To differentiate, OTel usesspan.kindand we usesentry.op(as well assentry.kindfor OTLP AFAIK).Why do we need yet another URL attribute then?
This PR adds a new attribute to serve a specific purpose: Provide the URL of the instrumented application on every span, regardless of its kind/op. We need this to be able to make Sentry's "filter out events from localhost" inbound filter work. This includes
http.client(outgoing request) spans. Theirurl.*attributes point to the request URL, so we can't set them to the application's URL. There are other spans like this, where we have similar issues (resource spans, db spans to a degree, etc).Why the
sentry.*Prefix?Initially I wanted to go with
app.url.domain, but then saw that OTel defines theappnamespace as "attributes related to client-side applications". So I'd prefer not "misusing" this namespace for server-side applications.Why this specific name?
url.domainalready exists. Prefixing it withsentry.app.means we re-use an established pattern for a more specific purpose.Alternatives considered?
browser.document.url.domain(something similar is in OTel) andhttp.server.url.domainfor the server-side.sentry.inbound_filter.url.domainPR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: