Skip to content

chore(attributes): Clarify parameter name casing - #632

Merged
Lms24 merged 4 commits into
mainfrom
lms/chore-clarify-parameter-name-spelling
Sep 9, 2026
Merged

chore(attributes): Clarify parameter name casing#632
Lms24 merged 4 commits into
mainfrom
lms/chore-clarify-parameter-name-spelling

Conversation

@Lms24

@Lms24 Lms24 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Came up via getsentry/sentry-javascript#24222

Makes it more explicit that we should follow established name patterns rather than force-normalize them, giving a couple of examples. The snake_case recommendation still stands, for example when we make up our own multi-word attributes like *.web_vitals.*.

@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners September 9, 2026 14:21
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Descriptions

  • Add more fine grained function.gcp span description rules by Lms24 in #624
  • Add graphql span description rules by Lms24 in #616

Names

  • Add FAAS function span name and description rules by Lms24 in #617
  • Add function span name and description rules by Lms24 in #618
  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Other

  • (op) Add mobile OTA update span operations by antonis in #540
  • (search-attributes) Add search attribute names by nsdeschenes in #610

Bug Fixes 🐛

  • (descriptions) Add graphql-enhanced http.client span description template by Lms24 in #613

Internal Changes 🔧

Deps

  • Bump sharp from 0.35.3 to 0.35.4 by dependabot in #630
  • Bump js-yaml from 4.3.1 to 4.3.2 by dependabot in #631
  • Bump svgo from 4.0.2 to 4.1.0 by dependabot in #627
  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Names

  • Clarify GraphQL OTel divergence note by andreiborza in #626
  • Add OTel divergence note for graphql span names by Lms24 in #615

Other

  • (attributes) Clarify parameter name casing by Lms24 in #632
  • (deps-dev) Bump vitest from 4.1.9 to 4.1.11 by dependabot in #629
  • (descriptions) Fix http.client span description example by Lms24 in #603

🤖 This preview updates automatically when you update the PR.

@nsdeschenes nsdeschenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 😄

@Lms24 Lms24 self-assigned this Sep 9, 2026
@Lms24
Lms24 enabled auto-merge (squash) September 9, 2026 14:32
@Lms24
Lms24 merged commit 90c9846 into main Sep 9, 2026
17 checks passed
@Lms24
Lms24 deleted the lms/chore-clarify-parameter-name-spelling branch September 9, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants