chore(attributes): Clarify parameter name casing - #632
Merged
Conversation
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 9, 2026 14:21
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Descriptions
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Names
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up via getsentry/sentry-javascript#24222
Makes it more explicit that we should follow established name patterns rather than force-normalize them, giving a couple of examples. The snake_case recommendation still stands, for example when we make up our own multi-word attributes like
*.web_vitals.*.