feat(replays): Define replayId as a deprecated attribute - #401
Merged
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
approved these changes
May 22, 2026
SDKs currently send `replayId` on spans, but we'd like to standardize on `sentry.replay_id` (already defined and in use for other telemetry types). Marking it as deprecated lets the product transparently query either name and return results for either attribute.
mjq
force-pushed
the
mjq/replayid-alias
branch
from
September 11, 2026 17:40
ff09ad8 to
69751cf
Compare
mjq
marked this pull request as ready for review
September 11, 2026 17:41
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+11
to
+14
| "deprecation": { | ||
| "_status": null, | ||
| "replacement": "sentry.replay_id" | ||
| }, |
There was a problem hiding this comment.
Bug: The replayId attribute has _status: null, which prevents it from being correctly linked to the sentry.replay_id deprecation chain, leading to incomplete query results.
Severity: MEDIUM
Suggested Fix
In model/attributes/replayId.json, change the _status field from null to "normalize". This will classify it as a rewriting deprecation and ensure it is correctly linked into the sentry.replay_id deprecation chain.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: model/attributes/replayId.json#L11-L14
Potential issue: The `replayId` attribute is being deprecated with `_status: null` in
`replayId.json`. The `isRewritingDeprecation` function requires a non-null status to
identify a rewriting deprecation. Because the status is null, the
`deriveAttributeKeyChains` function fails to link `replayId` to the deprecation chain of
its canonical name, `sentry.replay_id`. This results in `replayId` having an isolated
deprecation chain, which prevents queries for `sentry.replay_id` from including results
from `replayId`, contrary to the PR's goal of transparently querying either name.
Also affects:
javascript/sentry-conventions/src/search.ts:9753~9758
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SDKs currently send
replayIdon spans, but we'd like to standardize onsentry.replay_id(already defined and in use for other telemetry types). Marking it as deprecated lets the product transparently query either name and return results for either attribute.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.