ref(send-event): Introduce constant for max breadcrumbs - #2716
Merged
Conversation
While investigating #2709, I noticed the max breadcrumbs limit was hardcoded in multiple locations. This change extracts the value into a constant, so it is easier to change later, if we ever need to.
lcian
approved these changes
Sep 12, 2025
lcian
left a comment
lcian
left a comment
Member
There was a problem hiding this comment.
Looks good.
I think it would be better to define it only in one place but I think I understand why you did it like this. If you later want to make this a CLI argument, you would have to add it in both places anyways
szokeasaurusrex
deleted the
szokeasaurusrex/max-breadcrumbs-constant
branch
September 12, 2025 09:37
Member
Author
|
Yeah, I think that is exactly why I did it this way, as each command should define its limit separately. Also, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #2709, I noticed the max breadcrumbs limit was hardcoded in multiple locations. This change extracts the value into a constant, so it is easier to change later, if we ever need to.