Repository navigation
Reproduction for sentry-python#8027 - #61
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Johannes Daxböck <johannes.daxboeck@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction for getsentry/sentry-python#8027. That issue covers flaky Django cache span tests in streaming mode:
test_cache_spans_item_size[True]andtest_cache_spans_decorator[True].What it shows
With
trace_lifecycle="stream", each segment that finishes adds its trace toSpanBatcher._pending_flush, and that attribute is aset. If the flusher wakes after two segments have both finished, it sends them in hash order instead of the order they finished. The Django tests read spans by position across two requests, so request 2's cache hit can show up asspans[0].Run it
The script exits 1 with
BUG REPRODUCEDwhen the traces are sent out of order.Local results (Python 3.12.15, sentry-sdk 2.72.0)
--delay-flusher: 146 of 300 iterations were out of order.via johdax.
--
View Junior Session [Sentry]