fix(config): Fix inconsistent defaults for configs

[Dav1dde]

Depending on how you instantiate the config you either get the derived Default or the serde default. Always use serde(default) on the struct, always implement Default.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c569636. Configure here.}

[cursor]

Partial config uses wrong defaults

High Severity

Container #[serde(default)] fills omitted keys with each field type’s Default, not values from the struct’s impl Default. Removing field-level serde(default = …) on Processing, EnvelopeSpool, and AuthConfig makes partial YAML (e.g. only enabled or path) deserialize with zeros, empty strings, or None instead of documented defaults like max_secs_in_future 60, signature_max_age 300, or spool limits.

Additional Locations (2)

• relay-config/src/config.rs#L942-L1027
• relay-config/src/config.rs#L1526-L1541

 

^{Reviewed by Cursor Bugbot for commit c569636. Configure here.}

[Dav1dde]

You're drunk: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=ee94898216a1fff16c7a45406d7db992

[loewenheim]

Also serde's docs: https://serde.rs/container-attrs.html#default

[loewenheim]

In addition to being correct it's also much nicer to read.