Skip to content

fix(bigtable): Make RPC timeout configurable - #611

Merged
jan-auer merged 1 commit into
mainfrom
fix/bigtable-rpc-timeout
Sep 4, 2026
Merged

fix(bigtable): Make RPC timeout configurable#611
jan-auer merged 1 commit into
mainfrom
fix/bigtable-rpc-timeout

Conversation

@jan-auer

@jan-auer jan-auer commented Sep 4, 2026

Copy link
Copy Markdown
Member

Objectstore currently allows each Bigtable RPC attempt to run for 10 seconds. With two retries, this can exceed Envoy’s 15-second per-try timeout.

Add a configurable Bigtable rpc_timeout with a default of 2 seconds. The timeout is intentionally short so stalled RPCs fail faster and Objectstore can retry within Envoy’s upstream timeout budget.

getsentry/ops#23284 makes the corresponding Envoy route timeout budgets explicit.

Ref FS-502

@jan-auer
jan-auer requested a review from a team as a code owner September 4, 2026 11:43
@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

FS-502

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.77%. Comparing base (d25b10b) to head (d7ffa19).

Files with missing lines Patch % Lines
bigtable-bench/src/main.rs 0.00% 1 Missing ⚠️
objectstore-service/src/backend/bigtable.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   88.77%   88.77%   -0.01%     
==========================================
  Files         108      108              
  Lines       18116    18126      +10     
==========================================
+ Hits        16083    16091       +8     
- Misses       2033     2035       +2     
Components Coverage Δ
Rust Backend 92.59% <90.90%> (+<0.01%) ⬆️
Rust Client 81.97% <ø> (ø)
Python Client 93.56% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit 1bc77e1 into main Sep 4, 2026
26 checks passed
@jan-auer
jan-auer deleted the fix/bigtable-rpc-timeout branch September 4, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants