ref(service): Simplify semantic service errors - #606
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Member
Author
|
After iterating on this a bit more, this approach doesn't work at all. Since backtraces are not stabilized, I'm not able to find a good API that allows us to capture them with the tracing integration. We will instead go back to tracking custom context descriptions for now. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f31d3c. Configure here.
…errors * origin/main: ref(bigtable): delete_non_tombstone no longer emits extra delete in no-op case (#610) feat(server): Make Sentry stack traces configurable (#608) feat(server): Add Resumable Upload API (#593) # Conflicts: # objectstore-server/src/endpoints/common.rs # objectstore-service/src/error.rs
jan-auer
commented
Sep 2, 2026
lcian
reviewed
Sep 3, 2026
lcian
reviewed
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the service error enum with an opaque error and semantic error kinds.
Preserve backend response details as structured source errors. Classify panics, client stream failures, corrupt data, and capacity failures consistently across service and server code. The server now only needs to match on the public "kind", but not on the full enum with potentially nested errors.
These errors still don't capture backtraces, so we rely on the error kind + manual context to locate them precisely.
Replaces #547
Closes FS-446
Ref FS-358