Repository navigation
Persist Welcome completion across launches - #381
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the Welcome completion persistence change.
No open issues 🎉
What changed in this PR
Fixes Welcome completion persistence across launches, addressing #378 while leaving the broader onboarding redesign in #3 out of scope.
Changes:
- Allows validated saves of the internal
onboardingVersionsetting. - Saves Welcome state immediately instead of using the settings debounce.
- Adds a regression test for completion across restart, explicit reopening, and invalid-value rejection.
| File | Description |
|---|---|
src/hooks/useAppSettings.ts |
Saves onboarding state without debounce. |
src-tauri/src/settings_service.rs |
Tests onboarding persistence, reopening, and validation. |
shared/settings-contract.json |
Permits direct validated updates to onboardingVersion. |
Review effort: Balanced
JJJ
force-pushed
the
codex/onboarding-persistence
branch
from
November 10, 2026 06:25
a4e17a3 to
7dd0d68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onboardingVersionsetting to use the validated save path invoked by Welcome and Settings.Closes #378
Related to #3.
Validation
npm run test:frontendnpm run test:native