Skip to content

Persist Welcome completion across launches - #381

Merged
JJJ merged 1 commit into
mainfrom
codex/onboarding-persistence
Nov 10, 2026
Merged

JJJ merged 1 commit into
mainfrom
codex/onboarding-persistence

Conversation

@JJJ

@JJJ JJJ commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Allow the internal onboardingVersion setting to use the validated save path invoked by Welcome and Settings.
  • Save Welcome completion immediately rather than waiting for the usual settings debounce.
  • Add a persistence test covering completion, relaunch, reopening, and invalid values.

Closes #378

Related to #3.

Validation

  • npm run test:frontend
  • npm run test:native

@JJJ
JJJ marked this pull request as ready for review November 2, 2026 16:23
Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the Welcome completion persistence change.

No open issues 🎉

What changed in this PR

Fixes Welcome completion persistence across launches, addressing #378 while leaving the broader onboarding redesign in #3 out of scope.

Changes:

  • Allows validated saves of the internal onboardingVersion setting.
  • Saves Welcome state immediately instead of using the settings debounce.
  • Adds a regression test for completion across restart, explicit reopening, and invalid-value rejection.
File Description
src/​hooks/​useAppSettings.ts Saves onboarding state without debounce.
src-tauri/​src/​settings_service.rs Tests onboarding persistence, reopening, and validation.
shared/​settings-contract.json Permits direct validated updates to onboardingVersion.

Review effort: Balanced

@JJJ
JJJ force-pushed the codex/onboarding-persistence branch from a4e17a3 to 7dd0d68 Compare November 10, 2026 06:25
@JJJ
JJJ merged commit 931cead into main Nov 10, 2026
18 checks passed
@JJJ
JJJ deleted the codex/onboarding-persistence branch November 10, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Welcome reappears on every launch after completion

2 participants