Skip to content

Fix Linux tray icon style and initial visibility - #380

Merged
JJJ merged 1 commit into
mainfrom
codex/linux-tray-icon-style
Nov 10, 2026
Merged

JJJ merged 1 commit into
mainfrom
codex/linux-tray-icon-style

Conversation

@JJJ

@JJJ JJJ commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Make the Clipboard/Copycat tray icon style control available on Linux, with complete localization.
  • Use high-contrast Linux tray assets that remain visible in Omarchy's light and dark tray treatments.
  • Apply the saved style on startup and explicitly publish the initial Linux icon after creating the tray icon.

Closes #377

Validation

  • npm run test:frontend
  • npm run test:native
  • Regenerated both Linux tray assets and confirmed their rendered pixels match the committed files.
  • Manual Omarchy validation confirmed that the selected icon appears immediately after restart and both styles can be selected.

@JJJ
JJJ marked this pull request as ready for review November 2, 2026 16:23
Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Linux tray-icon startup and style-selection changes.

No open issues 🎉

What changed in this PR

Addresses #377 by making Linux tray icons visible at startup and exposing the Clipboard/Copycat style selector in General settings.

Changes:

  • Extracts tray settings into a shared component and enables style selection on Linux.
  • Generates high-contrast Linux icons, loads the saved style, and explicitly publishes the initial icon after tray creation.
  • Adds the system-tray label across all shipped locales and documents the Linux assets.
File Description
src/​locales/​pt-BR.json Adds the Brazilian Portuguese tray-icon label.
src/​locales/​ja-JP.json Adds the Japanese tray-icon label.
src/​locales/​he.json Adds the Hebrew tray-icon label.
src/​locales/​fr-FR.json Adds the French tray-icon label.
src/​locales/​es.json Adds the Spanish tray-icon label.
src/​locales/​en.json Adds the canonical English tray-icon label.
src/​locales/​de-DE.json Adds the German tray-icon label.
src/​locales/​ar.json Adds the Arabic tray-icon label.
src/​components/​SettingsGeneralTrayControls.tsx Extracts tray controls and enables Linux style selection.
src/​components/​SettingsGeneralPanel.tsx Uses the extracted tray-controls component.
src-tauri/​src/​app_tray.rs Loads platform-specific icons, applies saved styles, and publishes the initial Linux icon.
src-tauri/​ICON_ASSETS.md Documents high-contrast Linux tray assets.
scripts/​generate-icons.sh Generates Linux tray icons with white outlines.

Review effort: Balanced

@JJJ
JJJ force-pushed the codex/linux-tray-icon-style branch from 25739dd to 73fe379 Compare November 10, 2026 06:39
@JJJ
JJJ merged commit 65ba22b into main Nov 10, 2026
18 checks passed
@JJJ
JJJ deleted the codex/linux-tray-icon-style branch November 10, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux tray icon is blank and icon style control is unavailable

2 participants