Conversation
…n#724 Before committing to a fix for the headphone-drops-mid-recording issue, we need real evidence on which of three mechanisms is responsible: USB selective suspend, WASAPI render-endpoint idle, or the headset's own firmware auto-off power timer. A silent keep-alive stream only helps with the first two. Adds WasapiDeviceWatcher, an IMMNotificationClient that logs render/ capture endpoint state transitions as structured JSON events for the duration of a recording. Diagnostic only -- no recording behavior changes. Opt-in via OPENSCREEN_WGC_LOG_AUDIO_DEVICE_EVENTS=1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for #724 — this is diagnostic instrumentation only, not a fix yet.
Per the discussion on the issue, before committing to a keep-alive-stream fix we need real evidence on which of three mechanisms is causing headphones to drop mid-recording: USB selective suspend, WASAPI render-endpoint idle, or the headset's own firmware auto-off timer. A silent keep-alive stream only helps with the first two.
This adds
WasapiDeviceWatcher, anIMMNotificationClientthat logs render/capture endpoint state transitions as structured JSON events for the duration of a recording. It changes no recording behavior — opt-in only, viaOPENSCREEN_WGC_LOG_AUDIO_DEVICE_EVENTS=1.Opening this as a draft mainly to get Windows CI to compile-check it (my local VS Build Tools install is currently broken and I can't build locally yet). Will report back on the issue once I've captured real device-state events during a reproduction on my hardware.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com