Repository navigation
fix: bound REALITY handshakes and preserve JLS verification - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounds REALITY's pre-authentication work while preserving long-lived fallback traffic.
RealityConfig.HandshakeTimeoutdefaults to 15 seconds and is lifted after successful authentication/handshake or fallback selection. Pending client and target sockets close on timeout or context cancellation, and mirror connections forward deadline calls.Also addresses the related audit findings:
AfterBytes.VerifyPeerCertificateandVerifyConnectioncallbacks after JLS authentication; rejection still fails the handshake.Validation:
go test -race -count=1 -timeout 10m ./...passed.go test -count=1 -timeout 10m ./...passed.No protocol format or module-path changes. No release tags are created.