Repository navigation
Conversation
Go 1.26 on Linux and Windows with go vet, the minimum Go 1.20 on Linux, and a race detector run. Replaces the upstream matrix of 30 jobs.
Go before 1.24 does not generate a serial number when the template has none, so CreateCertificate failed on Go 1.20.
The client goroutine in testUtlsHandshake assigned the ApplyPreset result to the named return err, which the test goroutine also writes, and returned without sending on errChan when it failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our fork's changes land in
citrusthrough pull requests now, so they need a CI gate. Go 1.26 on Linux and Windows (withgo vet), the minimum Go 1.20 from go.mod on Linux, andgo test -raceon Linux. Replaces the upstream workflow, which ran 30 jobs (5 OSes × 6 Go versions) on every push.