Surface error cause chain in CLI error messages - #1190
Open
sholub-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1189. Node's fetch rejects with a constant
TypeError: fetch failedand keeps the actionable error (e.g.connect EPERM 127.0.0.1:38886) on.cause, but the CLI'sgetErrorMessageonly read.message, so every fetch failure printed the same uninformativeError: fetch failed.Unwrap the cause chain when formatting errors, joining messages with
:(a seen-set stops cyclic chains). A sandbox-blocked connection now printsError: fetch failed: connect EPERM 127.0.0.1:38886instead, which distinguishes a blocked connection from a server that is actually down. The existing ECONNREFUSED mapping to "Cannot connect to BB server" is unchanged.