Replay migrations skipped behind newer applied ledger rows - #1187
Open
sholub-dev wants to merge 1 commit into
Open
Replay migrations skipped behind newer applied ledger rows#1187sholub-dev wants to merge 1 commit into
sholub-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1186. Drizzle's sqlite migrator only applies journal entries whose timestamp is newer than the ledger's max
created_at. A single branch-local migration row with a newer timestamp (e.g. from running a dev build) therefore makes it skip every later published migration, andvalidateAppliedMigrationHistorythen fails startup with "Database migration history is incomplete after migration".After the Drizzle pass, replay journal migrations that are missing from the ledger and newer than the newest applied journal entry. Gaps older than that are still reported by validation as before. This generalizes the existing one-off repairs for skipped migrations (e.g. the branch-local thread-tabs repair), whose timestamps can't be enumerated upstream.
Verified locally. Able to start the app after the fix.