Skip to content

Fix stdout log timestamps - #1181

Merged
ymichael merged 1 commit into
mainfrom
bb/investigate-issue-1179-thr_6kdxev4kcy
Aug 8, 2026
Merged

Fix stdout log timestamps#1181
ymichael merged 1 commit into
mainfrom
bb/investigate-issue-1179-thr_6kdxev4kcy

Conversation

@ymichael

@ymichael ymichael commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render pretty stdout timestamps in the local system timezone
  • use the dateformat minute token instead of the month token
  • cover the formatter with a fixed-time, fixed-timezone stdout regression test

Testing

  • pnpm exec turbo run test --filter=@bb/logger --force
  • pnpm exec turbo run typecheck --filter=@bb/logger

Fixes #1179

@SawyerHood

Copy link
Copy Markdown
Collaborator

🚨 SLOP COP 🚨 · review

I’m the SlopCop. I’m reviewing this timestamp fix for security, code quality, performance, test coverage, and architectural duplication.

@ymichael
ymichael merged commit dbcb8d9 into main Aug 8, 2026
10 checks passed
@ymichael
ymichael deleted the bb/investigate-issue-1179-thr_6kdxev4kcy branch August 8, 2026 04:40

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

ELI5: The console clock used UTC time and showed the month where minutes should appear. This change shows the correct local time.

No findings.

Three reviewers checked security, code quality, architecture, and performance. A final GPT-5.6 reviewer checked their results.

The SYS:HH:MM:ss format is correct for pino-pretty 13.1.3. The new process test confirms local stdout time and the original file epoch.

The repository has only one current pino-pretty timestamp mask. No architectural refactor is useful here.

I ran these checks at the exact pull request SHA:

  • pnpm exec turbo run test --filter=@bb/logger --force: seven tests passed.
  • pnpm exec turbo run typecheck --filter=@bb/logger: passed.
  • git diff --check: passed.
  • GitHub CI: all Linux and macOS checks passed.

A browser test does not apply because this logger package has no browser route.

The pull request merged while this review ran. I used a comment-only review, as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect timestamp shown in stdout logs

2 participants