Fix stdout log timestamps - #1181
Conversation
|
🚨 SLOP COP 🚨 · I’m the SlopCop. I’m reviewing this timestamp fix for security, code quality, performance, test coverage, and architectural duplication. |
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: The console clock used UTC time and showed the month where minutes should appear. This change shows the correct local time.
No findings.
Three reviewers checked security, code quality, architecture, and performance. A final GPT-5.6 reviewer checked their results.
The SYS:HH:MM:ss format is correct for pino-pretty 13.1.3. The new process test confirms local stdout time and the original file epoch.
The repository has only one current pino-pretty timestamp mask. No architectural refactor is useful here.
I ran these checks at the exact pull request SHA:
pnpm exec turbo run test --filter=@bb/logger --force: seven tests passed.pnpm exec turbo run typecheck --filter=@bb/logger: passed.git diff --check: passed.- GitHub CI: all Linux and macOS checks passed.
A browser test does not apply because this logger package has no browser route.
The pull request merged while this review ran. I used a comment-only review, as required.
Summary
Testing
pnpm exec turbo run test --filter=@bb/logger --forcepnpm exec turbo run typecheck --filter=@bb/loggerFixes #1179