Allow custom ACP agents to declare provider-native skill roots - #1175
Draft
smsunarto wants to merge 3 commits into
Draft
Allow custom ACP agents to declare provider-native skill roots#1175smsunarto wants to merge 3 commits into
smsunarto wants to merge 3 commits into
Conversation
smsunarto
marked this pull request as draft
August 8, 2026 01:38
Amp-Thread-ID: https://ampcode.com/threads/T-019fdef6-db60-767b-a436-416e2bb11fa4 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fdef6-db60-767b-a436-416e2bb11fa4 Co-authored-by: Amp <amp@ampcode.com>
smsunarto
force-pushed
the
feat/custom-acp-native-skill-roots
branch
from
August 8, 2026 03:39
dcc7940 to
f8c68ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
customAcpAgentscan launch and configure ACP agents, but they cannot tell BB where those agents discover provider-native skills. As a result, composer command discovery is empty for custom ACP providers such asacp-amp, even when the underlying agent has its own native skill directories.Proposal
Add optional
nativeSkillRootsconfig to eachcustomAcpAgentsregistration:{ "nativeSkillRoots": { "user": [".amp/skills"], "project": [".amp/skills"] } }User roots resolve relative to the target execution host home directory. Project roots resolve relative to the selected workspace and are skipped when command discovery has no workspace. The daemon scans each configured root as a provider-native skill directory containing
<name>/SKILL.md.This threads the config through the ACP launch spec used by host command discovery, so the existing provider-native root resolver can discover configured ACP skill roots without an
acp-ampspecial case.Why
Custom ACP providers should get the same composer command discovery path that built-in provider-native skills use. Keeping the roots declarative in
customAcpAgentslets each custom provider describe its own native skill layout while preserving BB-owned policy for merging, de-duplication, and display.Verification
pnpm exec vitest run --config vitest.config.ts test/bb-app-managed-config.test.tsinpackages/configpnpm exec vitest run --config vitest.config.ts test/contract.test.tsinpackages/host-daemon-contractpnpm exec vitest run --config vitest.config.ts src/command-discovery.test.tsinapps/host-daemonpnpm exec vitest run --config vitest.config.ts test/public/public-project-commands.test.tsinapps/serverpnpm exec vitest run --config vitest.config.ts test/templates.test.tsinpackages/templatespnpm exec turbo run typecheck --filter=@bb/config --filter=@bb/host-daemon-contract --filter=@bb/host-daemon --filter=@bb/server --filter=@bb/templatespnpm exec turbo run test --filter=@bb/config --filter=@bb/host-daemon-contract --filter=@bb/host-daemon --filter=@bb/server --filter=@bb/templatespnpm exec prettier --check <changed non-ignored files>git diff --check