fix(cli): install plugin scaffold dev dependencies - #1135
Draft
galligan wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bb plugin new --appexplicitly include development dependencies in its npm installNODE_ENV=productionand records the npm arguments through a fake executableRoot cause
The packaged CLI inherits
NODE_ENV=production. The scaffold stores required build and type packages indevDependencies, but the CLI launched plainnpm install. npm therefore omitted those packages while exiting successfully, so the CLI reported that dependencies were installed even though the new plugin could not build.Passing
--include=devmakes the CLI-owned install independent of the parent process environment.User impact
A successful
bb plugin new <name> --appdependency installation now leaves the generated plugin ready forbb plugin buildwithout a second manual install.Validation
pnpm exec turbo run test --filter=@bb/cli --force— 369 tests passedpnpm exec turbo run typecheck --filter=@bb/clipnpm exec prettier --check apps/cli/src/__tests__/plugin-new.test.tsgit diff --checkFixes #1133