Repository navigation
Tokenise before calling ntoken() on corpus objects - #107
Merged
Merged
Conversation
quanteda has deprecated ntoken() on corpus and character input since 4.0, and now warns about it, which makes the "summarise_oolong problem gesistsa#59" test fail because it expects no warnings. Call ntoken(tokens(x)) in .length_plot() and the gold-standard summary, and in the overview vignette. Counts are unchanged, and the code works with older quanteda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quanteda has deprecated
ntoken()on corpus and character input since 4.0. The upcoming quanteda 4.5.1 now emits the deprecation warning, which makes the "summarise_oolong problem #59" test fail because it asserts there are no warnings (found by reverse-dependency checks).This calls
ntoken(tokens(x))instead, in.length_plot(), the gold-standard summary and the overview vignette. Token counts are unchanged, and the code works with older quanteda, so thequanteda (>= 3.0.0)requirement is unaffected.test-summarize_oolong.Rpasses with no warnings under both quanteda 4.5.0 (CRAN) and the development 4.5.1.