Repository navigation
Conversation
fredj
marked this pull request as ready for review
October 22, 2026 08:23
tonio
reviewed
Oct 27, 2026
The list endpoint returns a `total` field on the first page: the number of links matching the current filters that the listing keeps, those without a staging or final table excluded. It is counted from a single query selecting only the columns that check reads, so it cannot go negative from a link created between two queries. Later pages return null instead of counting again. The dashboard shows it next to "Filtrer vos données", taken from the first page, and decremented on delete.
fredj
force-pushed
the
feat/dashboard-result-count
branch
from
October 30, 2026 08:39
c92cff8 to
2bc1c54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard only lists a page of datasets at a time, so users could not tell how many datasets match their current search and filters. It now shows the total next to "Filtrer vos données", e.g. "Filtrer vos données - 1005 résultats".
totalfield: the SQL count of links matching the filters, minus the links the listing drops because neither their staging nor their final table exists. It is exact and identical on every page. This costs one extra query per list request, limited to non-empty links.integrityLinks.filters.resultCountkey is added to all translation files (fr and en filled in)./dataset/, not/datafeeder/.Checked in the browser against a dev database: the total matched the number of datasets reachable through "Charger plus" (386), and with a search term (32 results, 32 rows).