fix(etl): replace str.format with regex to avoid brace conflicts - #138
Open
C1-BA-B1-F3 wants to merge 2 commits into
Open
C1-BA-B1-F3 wants to merge 2 commits into
C1-BA-B1-F3 wants to merge 2 commits into
Conversation
base64.encodestring was removed in Python 3.9 and expected a str in Python 3 (raising TypeError: expected bytes-like object, not str). Use base64.b64encode with explicit UTF-8 encode/decode, which works on all Python 3 versions. Fixes geopython#130
Config argument substitution used str.format(), which interprets any
{} in the config string as a format placeholder. Config values like
converter_args that contain dict literals (e.g. {'root_tag': ...})
triggered KeyError on the dict keys.
Use a regex that only replaces {argname} placeholders, leaving literal
braces untouched.
Fixes geopython#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config argument substitution used
str.format(), which interprets any{}in the config string as a format placeholder. Config values likeconverter_argsthat contain dict literals triggerKeyErroron the dict keys:Fix
Replace
str.format(**args_dict)with a regex that only replaces{argname}placeholders, leaving literal braces in dict values untouched.Test plan
{foo}placeholders are substituted while{'root_tag': ...}dict literals remain intact.Fixes #124