Skip to content

Detect URLs by scheme in read_data - #2420

Open
Shubham-Padkonde wants to merge 1 commit into
geopython:masterfrom
Shubham-Padkonde:fix/read-data-url-detection
Open

Shubham-Padkonde wants to merge 1 commit into
geopython:masterfrom
Shubham-Padkonde:fix/read-data-url-detection

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown
Contributor

read_data treated any string starting with "http" or "s3" as a URL, so a local relative path such as httpdata/file.nc or s3cache/file.tif was passed to urlopen and failed with "ValueError: unknown url type". Check the URL scheme instead.

Overview

Related Issue / discussion

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

read_data treated any string starting with "http" or "s3" as a URL, so
a local relative path such as httpdata/file.nc or s3cache/file.tif was
passed to urlopen and failed with "ValueError: unknown url type".
Check the URL scheme instead.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant