Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenSearch(..., xml=...)raisesAttributeError: 'NoneType' object has no attribute 'split'when the description document omits<Tags>. The OpenSearch 1.1 specification explicitly allows Tags to appear zero or one time:https://github.com/dewitt/opensearch/blob/master/opensearch-1-1-draft-6.md#the-tags-element
An empty
<Tags/>produces the same exception. As a result, an otherwise usable description cannot be loaded.Fix
Normalize an absent Tags text value to an empty string before splitting, returning an empty list. Existing tag splitting is unchanged.
Add synthetic XML regression coverage through the public
OpenSearchconstructor for missing, empty, whitespace-only, and populated Tags. The tests also check that the short name and URL template remain available. They do not make network requests.Validation
Python 3.12.10, Windows:
python -m flake8 owslib/ tests/test_opensearch.py: passed.git diff --check: passed.I did not run online service tests or build the documentation.
AI assistance was used to investigate, implement, and test this change.