fix(helm): retain GitLab merge-request links in card facts - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Captain wants a direct link to the PR/MR within the Helm sync card body, in the Facts section, so it's easy to jump to it from the card once a PR is opened.
What Changed
PRfacts in card bodies.Risk Assessment
✅ Low: The narrowly scoped parser change preserves canonical GitLab MR links alongside existing GitHub PR links, with behavioral coverage for accepted and rejected URL shapes.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 2 issues found → auto-fixed (2) ✅
bin/fm-helm-lib.sh:189- The new MR alternatives accept/merge_requests/0and numeric prefixes such as/merge_requests/12x; those are rendered as aPR:Facts link despite not being valid MR URLs. The shared PR parser requires a positive, complete IID. Tighten these new patterns to the same number boundary.bin/fm-helm-lib.sh:189- Simplification:/merge_requests/<n>is a new bare-GitLab alias, but the existing canonical PR/MR parser accepts only/-/merge_requests/<n>and no intent requirement calls for the alias. Remove this extra acceptance path and its test unless supporting manually supplied noncanonical GitLab links is intended.🔧 Fix: Tighten Helm PR URL recognition
1 warning still open:
docs/bugs/2026-09-14-helm-sync-multi-host-pr-link.md:16- The new bug note says the allowlist accepts bare GitLab/merge_requests/<number>URLs, but the parser accepts only/-/merge_requests/<number>and the amended integration test asserts that bare URLs are omitted. Update the Fix section to name only the two supported canonical shapes.🔧 Fix: Correct Helm PR-link documentation
✅ Re-checked - no issues remain.
bin/fm-test-run.sh --changed --exclude-family real-herdr-gated✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.